D28020: New class ProcessLauncherJob in KIOGui
David Faure
noreply at phabricator.kde.org
Fri Mar 13 11:02:17 GMT 2020
dfaure created this revision.
dfaure added reviewers: apol, davidedmundson, nicolasfella, vkrause, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
This is meant to replace KRun::runApplication/runService,
without the QWidget dependency, for most use cases. One exception:
applications who want to allow the user to make desktop files executable
(this requires messageboxes, and therefore is still in KRun).
The code is mostly based on KRun's internal KProcessRunner class,
now moved to KIOGui, but still private.
Next step: also routing KRun::runCommand via ProcessLauncherJob,
and then writing OpenUrlJob on top of ProcessLauncherJob (but
runUrl calling KOpenWithDialog is a problem in KIOGui...).
TEST PLAN
see new unittest (which is based on krununittest)
REPOSITORY
R241 KIO
BRANCH
2020_ProcessLauncherJob
REVISION DETAIL
https://phabricator.kde.org/D28020
AFFECTED FILES
autotests/CMakeLists.txt
autotests/kiotesthelper.h
autotests/processlauncherjobtest.cpp
autotests/processlauncherjobtest.h
src/gui/CMakeLists.txt
src/gui/config-kiogui.h.cmake
src/gui/kprocessrunner.cpp
src/gui/kprocessrunner_p.h
src/gui/processlauncherjob.cpp
src/gui/processlauncherjob.h
src/widgets/CMakeLists.txt
src/widgets/krun.cpp
src/widgets/krun.h
src/widgets/krun_p.h
To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200313/7d5ab600/attachment.html>
More information about the Kde-frameworks-devel
mailing list