D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, sitter, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Extend krununittest to test ktelnetservice.
  
  Use CMake target_compile_definitions() to set the CMAKE* vars that need
  to be accessed from the code in krununittest.

TEST PLAN
  $ kde-open5 ssh://user@1.1.1.1
  
    outputs:
    command= "ktelnetservice5 %u" args= ("ktelnetservice5 %u", "ssh://user@1.1.1.1")
    kf5.kio.core: couldn't create slave: "klauncher said: Unknown protocol 'ssh'.\n"
  
  and you get a message box with "File not found: ssh://user@1.1.1.1".
  
  Apply diff then try again, now a terminal window is launched by
  ktelnetservice5 and ssh is invoked as expected.
  
  BUG: 418258
  
  FIXED-IN: 5.69

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/krununittest.cpp
  autotests/krununittest.h
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200312/87869d3a/attachment-0001.html>