D25315: KDirModel: implement showing a root node for the requested URL

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kdirmodeltest_gui.cpp:92
> It doesn't look "normal" : without the ShowRoot feature, you wouldn't see the "/" root node.
> So I would say the test program is valid, no matter what the starting directory is.
> 
> (I was wrong about passing a path as argument, this goes into the code path that does NOT set ShowRoot)

I wasn't re-arguing for changing the path in the test app, just explaining my POV (and "normal" as in I expected, mentally, to see "/" as the parent, since, well, it is).

When I tested with /usr/share/fonts, I modified the source code directly. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200312/0837bd73/attachment.html>