D27133: kconfig_compiler : generate kconfig settings with subgroup

[Aleix Pol Gonzalez]

apol added a comment.


  The patch and the feature sound good to me, the resulting xml feels a bit weird and could use some clarification.

INLINE COMMENTS

> test_subgroups.kcfg:21
> +    </group>
> +    <group name="$(AnotherSubGroup)" parentGroupName="ParentGroup">
> +        <entry name="Baz" type="Bool">

It feels odd to reference the parent name rather than having a group inside the other.

Why don't we do something like:

  <group name="Potato">
      //entries
      <group name="SmallPotato">
          //entries
      </group>
  </group>

Might be missing something.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200311/405c40d7/attachment.html>