D26983: Enable adding place as first child

George Vogiatzis noreply at phabricator.kde.org
Mon Mar 9 19:43:34 GMT 2020


gvgeo added inline comments.

INLINE COMMENTS

> kfileplacesmodel.cpp:1059
>  {
> -    KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookmarkManager,
> -                         text, url, iconName);
> +    KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookmarkManager, text, url, iconName);
>  

It is a style change, but it is hardly unrelated, I copy this line above. I need to mirror the style for ease of reading. And, I'm not going to copy a "bad"(in lack of a better word) style.

REPOSITORY
  R241 KIO

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200309/424963b3/attachment.html>


More information about the Kde-frameworks-devel mailing list