D27883: Register spawned applications as an independent cgroups

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kprocessrunner.cpp:51
> +
> +std::once_flag dbusTypesRegistered;
> +

This could be in the function scope as static.

> kprocessrunner.cpp:281
> +{
> +    if (!qEnvironmentVariableIsSet("KDE_APPLICATIONS_AS_SCOPE")) {
> +        return;

Who defines this environment variable?

> kprocessrunner.cpp:301
> +    const QString mode = QStringLiteral("fail"); // mode defines what to do in the case of a name conflict, in this case, just do nothing
> +    NamedVariantList properties;
> +    QList<QPair<QString, NamedVariantList>> aux; // unused, but we need the signatue to be correct;

Declare and define together

> kprocessrunner.cpp:302
> +    NamedVariantList properties;
> +    QList<QPair<QString, NamedVariantList>> aux; // unused, but we need the signatue to be correct;
> +

*signatuRe

Also I'm not sure I understand...

> kprocessrunner.cpp:308
> +    message.setArguments({name, mode, QVariant::fromValue(properties), QVariant::fromValue(aux)});
> +    QDBusConnection::sessionBus().call(message);
> +}

Does this need to be sync?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200309/22e4fb25/attachment.html>