D25315: KDirModel: implement showing a root node for the requested URL

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kdirmodel.h:79
> That sounds more confusing to me, depending on how one thinks about all this.
> 
> There's nothing special about the first child compared to other direct children, one misinterpretation of your suggested sentence would be that the first child will be shown but not its siblings.
> 
> If ShowRoot is not set, then the given URL isn't shown, its children are. All of them :)

Fair point.

> dfaure wrote in kdirmodeltest_gui.cpp:92
> Making file:/// work was actually more trouble so it's worth having an easy way to test this. This is an interactive test anyway, you can pass /usr/share/fonts as argument if you want to test that path :-)

I did test the /usr/share/fonts path :); it's just that starting at "/" looked "normal", whereas starting at a specific dir conveyed the goal of this change better, to me anyway.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200308/d46f9e00/attachment.html>