D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kfilefiltercombo.cpp:156
> +        if (!type.isValid()) {
> +            qCDebug(KIO_KFILEWIDGETS_KFILEFILTERCOMBO) << *it << "is not a valid mimeType";
> +            continue;

IMHO it's a programmer error so it should be a qCWarning (visible by default), not a qCDebug (invisible by default).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200306/1ca8ed9a/attachment.html>