D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:57
> +ecm_qt_declare_logging_category(kiofilewidgets_SRCS
> +    HEADER kiofilewidgets_debug.h
> +    IDENTIFIER KIO_KFILEWIDGETS_KFILEFILTERCOMBO

Perhaps name the header matching kfilefiltercombo, to make clear this one is not providing the general library category.

> kfilefiltercombo.cpp:29
>  #include <QLineEdit>
> +#include <QLoggingCategory>
>  

Should not be needed, served by generated header already.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200305/bf403346/attachment-0001.html>