D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/
Ahmad Samir
noreply at phabricator.kde.org
Thu Mar 5 11:23:59 GMT 2020
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter, broulik.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
For trash:/ we have two individual cases:
- trash:/ itself, show empty/full trash icon
- trash:/file and trash:/folder/, show icon for the file mimetype or inode/directory respectively
Less if nesting by using a ternary.
This fixes the testtrash unit test.
Extend kfileitemtest to test all cases.
TEST PLAN
make && ctest
REPOSITORY
R241 KIO
BRANCH
l-trash-stuff (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27864
AFFECTED FILES
autotests/kfileitemtest.cpp
src/core/global.cpp
To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200305/23f5e533/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list