D27463: KconfigXT: Add a value attribute to Enum field choices
Méven Car
noreply at phabricator.kde.org
Thu Mar 5 09:44:09 GMT 2020
meven added inline comments.
INLINE COMMENTS
> ervin wrote in kcoreconfigskeleton.cpp:580
> Will need an update
You mean I should prepare this and put it in KF6 waiting for merge queue ?
> ervin wrote in kcoreconfigskeleton.h:788
> const QString &name
>
> Probably worth adding a KF6 comment somewhere as well, because your first attempt felt more natural, we're going for this weird construct only for BC concerns.
I have one in `QString KCoreConfigSkeleton::ItemEnum::valueForChoice(QString name) const`
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D27463
To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200305/52481548/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list