D27152: Introduce FilesystemEntry class

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filesystem_entry_test.h:6
> + *   it under the terms of the GNU General Public License as published by  *
> + *   the Free Software Foundation; either version 2 of the License, or     *
> + *   (at your option) any later version.                                   *

For tests LGPL is preferred as well. Also see D27742 <https://phabricator.kde.org/D27742>.

> filesystem_entry.cpp:31
> +    case Solid::Backends::Fstab::FilesystemType::FuseEncFs:
> +        return device + QLatin1Char('@') + mountPoint;
> +    case Solid::Backends::Fstab::FilesystemType::Unknown:

This is a behavioral change:

- overlayfs is no longer handled
- fuse.cryfs is no longer handled

- encfs gets an extra '@', and the prefix is changed from <fstype> to <device>

The identifier is API, don't change it. E.g. dolphin may reference it.

> filesystem_entry.h:5
> + *   This program is free software; you can redistribute it and/or modify  *
> + *   it under the terms of the GNU General Public License as published by  *
> + *   the Free Software Foundation; either version 2 of the License, or     *

This has to be LGPL.

Regarding wording, please have a look at D27742 <https://phabricator.kde.org/D27742> for how it should look like.

Applies to other files as well.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200304/ed33f707/attachment-0001.html>