D27801: smb: add a unit test for smburl
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Mar 3 19:51:01 GMT 2020
apol added a comment.
+1 from me
INLINE COMMENTS
> apol wrote in smburl.cpp:67
> Can't we then just rename the method to `::cdUp()`?
it can return void too, nobody is checking it anyway.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D27801
To: sitter, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200303/f78c6401/attachment.html>
More information about the Kde-frameworks-devel
mailing list