D27802: smb: fix ipv6 support
Harald Sitter
noreply at phabricator.kde.org
Tue Mar 3 10:49:24 GMT 2020
sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
libsmbc doesn't presently support smb://[ABCD::DCBA]/ uris because it
has very opinionated colon parsing. as a workaround we convert hosts
that are ipv6 addresses to their windows ipv6 literal representation.
that is basically s/:/-/g and s/%/s/g and appending .ipv6-literal.net.
BUG: 417682
FIXED-IN: 20.04
TEST PLAN
builds, test passes, `'smb://[::1]/foo'` works as expected
REPOSITORY
R320 KIO Extras
BRANCH
smb-smburl-static-autotest-ipv6
REVISION DETAIL
https://phabricator.kde.org/D27802
AFFECTED FILES
smb/autotests/smburltest.cpp
smb/smburl.cpp
To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200303/2dfbf3fb/attachment.html>
More information about the Kde-frameworks-devel
mailing list