D27765: [FileContentIndexer] Remove duplicate condition check for loop break
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sun Mar 1 16:56:30 GMT 2020
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Counting the number of files to be indexed (m_provider->size()) can
be significantly more costly than checking if the next batch is empty.
Also the m_stop condition was checked twice.
REPOSITORY
R293 Baloo
BRANCH
submit
REVISION DETAIL
https://phabricator.kde.org/D27765
AFFECTED FILES
src/file/filecontentindexer.cpp
To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200301/7028db58/attachment.html>
More information about the Kde-frameworks-devel
mailing list