D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)
Igor Poboiko
noreply at phabricator.kde.org
Thu Jun 4 23:17:33 BST 2020
poboiko added a comment.
In D29826#674634 <https://phabricator.kde.org/D29826#674634>, @aacid wrote:
> oh i think i'm too late :D
Whoops, sorry :S
Actually, I thought that if this piece of code is executed with Qt >= 5.15.1 (or whenever the proper fix is landed), it shouldn't hurt anyone anyways.
The TODO is more about code maintainability and reducing amount of various hacks in the code, and in that case another `#if` won't help much :)
> Let's wait for the fix to actually land and then i'll propose that change
OK! :)
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D29826
To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200604/f2d5d215/attachment-0001.htm>
More information about the Kde-frameworks-devel
mailing list