D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

[Albert Astals Cid]

aacid added a comment.


  oh i think  i'm too late :D

INLINE COMMENTS

> kmainwindow.cpp:253
> +    // TODO: remove this once we depend on Qt 5.15.1, where this is fixed
> +#if QT_VERSION >= QT_VERSION_CHECK(5, 12, 0)
> +    if (QIcon::fallbackThemeName().isEmpty()) {

should this be
#if QT_VERSION >= QT_VERSION_CHECK(5, 12, 0) && #if QT_VERSION < QT_VERSION_CHECK(5, 15, 1)
?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D29826

To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200604/010b5276/attachment.htm>