D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu added a comment.


  In D28745#675709 <https://phabricator.kde.org/D28745#675709>, @bruns wrote:
  
  > In D28745#675698 <https://phabricator.kde.org/D28745#675698>, @marcingu wrote:
  >
  > > > How often do I have to repeat the thumbnailer has to use the canonical path anyway? Please use that.
  > >
  > > `storageAccessFromPath` converts given path into canonical. I figured it should do so anyway, so I'm not doing it again here.
  >
  >
  > And thats wrong. You need the canonical path in the thumbnailer itself.
  
  
  Ok. Should this be done here in `createSubThumbnail` or earlier so the whole object uses canonical path?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200701/eeabccec/attachment.htm>