D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

Kevin Ottens noreply at phabricator.kde.org
Fri Jan 31 13:45:02 GMT 2020


ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Sorry, couple of further style fixes I missed on the previous run

INLINE COMMENTS

> kcoreconfigskeleton.cpp:1616
> +
> +void KConfigCompilerSignallingItem::setGroup(const KConfigGroup& cg)
> +{

Space before & not after

> kcoreconfigskeleton.cpp:1621
> +
> +KConfigGroup KConfigCompilerSignallingItem::configGroup(KConfig* config) const
> +{

Space before * not after

> kcoreconfigskeleton.h:453
> +    void setGroup(const KConfigGroup &cg);
> +    KConfigGroup configGroup(KConfig* config) const;
> +    // END TODO

Space before * not after

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200131/656368c9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list