D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

David Redondo noreply at phabricator.kde.org
Thu Jan 30 23:20:40 GMT 2020


davidre added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:39
> +
> +constexpr int borderSize = 2;
> +

I don't think so:

> internal linkage
> [...]
> variables, variable templates (since C++14), functions, or function templates declared static;
> non-volatile non-template (since C++14) non-inline (since C++17) non-exported (since C++20) const-qualified variables (including constexpr) that aren't declared extern and aren't previously declared to have external linkage;

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200130/c0a0be2a/attachment.html>


More information about the Kde-frameworks-devel mailing list