D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu
Méven Car
noreply at phabricator.kde.org
Thu Jan 30 08:39:41 GMT 2020
meven added inline comments.
INLINE COMMENTS
> kurlnavigatorplacesselector.cpp:75
> + // Submenus have to be deleted explicitly (QTBUG-11070)
> + for(QObject *obj : QObjectList(m_placesMenu->children())) {
> + delete qobject_cast<QMenu*>(obj); // Noop for nullptr
Shouldn't it be done before the call to `m_placesMenu->clear();`
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27002
To: fvogt, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200130/56066a21/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list