D26979: KWallet-PAM SELinux context transition support

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> CMakeLists.txt:17
> +find_library(SELINUX selinux)
>  
>  find_program(SOCAT_EXECUTABLE socat)

instead of message()

  set_package_properties(SELINUX PROPERTIES DESCRIPTION "some security thing"
                         TYPE OPTIONAL
                         PURPOSE "Do a security thing."
                        )

and then line

  feature_summary(WHAT ALL INCLUDE_QUIET_PACKAGES FATAL_ON_MISSING_REQUIRED_PACKAGES)

is better, it does the same thing you're doing but in a more parseable way

> pam_selinux.c:44
> +
> +	ret = security_compute_create(execcon, fcon, string_to_security_class ("process"), &newcon);
> +	if (ret < 0) goto err;

on the gnome patch this is the macro

SECCLASS_PROCESS

any reason for the difference?

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D26979

To: secureworkstation, #plasma, #frameworks
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200129/ab535bde/attachment.html>