D26983: [WIP]Enable adding place as first child

Méven Car noreply at phabricator.kde.org
Wed Jan 29 18:14:54 GMT 2020


meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  I am not a #Frameworks <https://phabricator.kde.org/tag/frameworks/> reviewer
  Please give some time to others to have a look as well

INLINE COMMENTS

> gvgeo wrote in kfileplacesmodel.cpp:1046
> As it is, with a  `null QModelIndex`, the function below will move the new item to the top.

I missed this, you could pass the current modelIndex or the first to save some code here, but that's just some nitpicking.

REPOSITORY
  R241 KIO

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200129/65990e17/attachment.html>


More information about the Kde-frameworks-devel mailing list