D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

Arjen Hiemstra noreply at phabricator.kde.org
Wed Jan 29 15:05:47 GMT 2020


ahiemstra added inline comments.

INLINE COMMENTS

> ksortfilterproxymodel.cpp:85
> +        QJSValueList args = {QJSValue(source_column), engine->toScriptValue(source_parent)};
> +        return const_cast<KSortFilterProxyModel *>(this)->m_filterCallback.call(args).toBool();
> +    }

This is using the wrong callback, it should be using m_filterColumnCallback

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: kmaterka, iasensio, ahmadsamir, broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200129/5a23ea7e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list