D26960: RFC: [KWindowShadows] Check for X connection

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  On teardown of plasmashell the shared pointer with shadows is unref'd quite late at which point `QX11Info::connection()` already return null, leading to a crash in those xcb calls.
  The old code in Plasma PanelShadows checked for `QX11Info::display()` being null, which is restored here.

TEST PLAN
  Not sure if this is a good idea? is X smart enough to clean up after us?
  
  - Still crashes in Breeze style but no longer without it

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D26960

AFFECTED FILES
  src/platforms/xcb/kwindowshadow.cpp

To: broulik, #plasma, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200128/6ce7ee6d/attachment.html>