D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Jan 27 14:19:19 GMT 2020


apol added inline comments.

INLINE COMMENTS

> kconfigloader.cpp:125
>          for (int i = 0; i < numAttrs; ++i) {
> -            QString name = attrs.localName(i).toLower();
> +            const QString name = attrs.at(i).name().toString().toLower();
>              if (name == QLatin1String("name")) {

You can use QStringRef::compare() in this if sequence over here too.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26890

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200127/146247a1/attachment.html>


More information about the Kde-frameworks-devel mailing list