D26650: Use KService to look for Filelight

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> sitter wrote in kpropertiesdialog.cpp:1114
> I'm pretty sure that isn't true.
> 
> KFilePropsPlugin are the tabs inside the properties dialog. They get instantiated for each dialog and destroyed when the dialog is destroyed. They are not persistent throughout the life time of the process. 
> The lamda in this case is scoped to the internal QFunctorSlotObject or whatever it's called and that is held by the QObject. When the dialog gets destroyed, it destroys the KFilePropsPlugin instance and that disconnects the signal triggering the QFunctorSlotObject to get deleted, which in turn causes the lambda to lose scope and clean up, destroying its pointer copies.
> TLDR: the lambda and all its copies do not outlive the property dialog it belongs to.

@shubham reimplement slotSizeDetails with `KService::serviceByDesktopName(QStringLiteral("org.kde.filelight"));` + `Krun::runApplication`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200126/8671c749/attachment.html>