D26900: Support multiple values in XDG_CURRENT_DESKTOP

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Jan 26 13:05:03 GMT 2020


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  The patch looks good to me.

INLINE COMMENTS

> apol wrote in kservice.cpp:658
> You can use QVector<QStringRef> here, it would save us constructing a bunch of strings for no reason. Maybe not in the general case of everyone having just the one desktop though.

This adds a "KDE" allocation on every which isn't ideal either. I don't know, maybe it doesn't matter either way...

REPOSITORY
  R309 KService

BRANCH
  xdg_current_deskto

REVISION DETAIL
  https://phabricator.kde.org/D26900

To: dfaure, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200126/72269151/attachment.html>


More information about the Kde-frameworks-devel mailing list