D25583: Quit baloo_file_extractor if DB transaction fails

[David Edmundson]

davidedmundson added a comment.


  > I will try to cook up a more complete solution over the weekend.
  
  If you can explain what you would prefer instead, I can help find time.

INLINE COMMENTS

> bruns wrote in app.cpp:119
> This is a little bit confusing, as the lmdb code uses `rc == LMDB_OK == 0`, but here `0 == ERROR`.

Sure, but engine is an abstraction layer over lmdb so you don't want to leak those details, and for a boolean it makes sense that true == good

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25583

To: davidedmundson, bruns, ngraham
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200124/7ab1973e/attachment-0001.html>