D26839: demote plugin load errors from warning to debug level + reword

Harald Sitter noreply at phabricator.kde.org
Wed Jan 22 12:36:32 GMT 2020


sitter created this revision.
sitter added a reviewer: mpyne.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  while they are errors from our POV the callers POV may be that
  they'll simply try another name. with the previous behavior
  we would always end up printing the message because warnings
  are visible by default and then on top of that the warning
  would use the word error.
  
  this lead to users getting confused about the actual impact:
  https://bugs.kde.org/show_bug.cgi?id=364637
  
  when the caller has additional handling:
  https://phabricator.kde.org/D26791
  
  the latter ought to always be the case as far as error reporting
  goes because the class documentation even suggests as much
  in its example snippet.
  
  as a result of all this it seems way more appropriate to
  consider this a debug message on a kcoreaddons level.
  additionally, the message now talks about failure to load rather
  than error loading so as to make it a bit less important
  sounding.

TEST PLAN
  -

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26839

AFFECTED FILES
  src/lib/plugin/kpluginloader.cpp

To: sitter, mpyne
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200122/b8727aa2/attachment.html>


More information about the Kde-frameworks-devel mailing list