D26801: Really fix the Windows backend for KNotifications

Piyush Aggarwal noreply at phabricator.kde.org
Tue Jan 21 03:08:32 GMT 2020


brute4s99 created this revision.
brute4s99 added reviewers: vonreth, broulik, KDE Connect.
brute4s99 added a project: KDE Connect.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  This patch fixes the Windows backend.
  The workaround was implemented by completing ditching the notification->id() thing, because it relies on updating the notification afterwards.
  
  Updating was not a viable option because WIndows 8 and 8.1 does not support updating a notification.

TEST PLAN
  Now the backend actually works and does not crash at every other notification like it used to.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26801

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200121/e1c30f73/attachment.html>


More information about the Kde-frameworks-devel mailing list