D26794: [WIP] Implement comment posting (and reenable voting)
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Mon Jan 20 14:37:24 GMT 2020
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
This is a work in progress for adding support for posting comments
to the KNewStuffCore framework, and cleaning up voting a touch. It
further adds UI for creating said comments to KNSQuick.
- Add signals to fake a virtual function for posting a comment
- Implement comment posting (and userCanVote check)
- Add invokable functions for creating comments (and reviews)
- Add voting function to the quickitemsmodel (and userCanVote role)
- Entry details checks for voting ability
- Don't allow voting from the list view (in the old dialog)
This does not strictly require D25961 <https://phabricator.kde.org/D25961>, but without it this will simply not allow voting and commenting with the attica backend
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26794
AFFECTED FILES
src/attica/atticaprovider.cpp
src/attica/atticaprovider_p.h
src/core/commentsmodel.cpp
src/core/commentsmodel.h
src/core/provider.h
src/qtquick/quickitemsmodel.cpp
src/qtquick/quickitemsmodel.h
src/ui/entrydetailsdialog.cpp
src/ui/itemsviewdelegate.cpp
To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200120/0a91e667/attachment.html>
More information about the Kde-frameworks-devel
mailing list