D26691: Optimize code when dropping files into the desktop

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> containmentinterface.cpp:548
> +
> +    if (!m_dropMenu->urls().at(0).isLocalFile()) {
> +        QApplication::restoreOverrideCursor();

can you be sure urls has at least 1 at this point?

> dropmenu.cpp:36
> +
> +DropMenu::DropMenu(KIO::DropJob *dropJob, QPoint dropPoint, ContainmentInterface *parent)
> +    : QObject(parent),

const QPoint &dropPoint

> dropmenu.cpp:48
> +        }
> +        connect(m_menu, &QObject::destroyed, this, &QObject::deleteLater);
> +    } else {

where does this menu get deleted? It seems to leak

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200120/b29ab321/attachment-0001.html>