D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Haven't tried the dolphin branch yet, just a comment on the API for now.
  From a quick look the patch looks good though.

INLINE COMMENTS

> kfileplacesview.h:68
> +     */
> +    bool showAll() const;
> +

This seems to be the name of a method that makes all items visible, not the name of a bool getter.

I know we already have `setShowAll()`, but we can deprecate it and find a better name. How about `setAllPlacesVisible()` / `allPlacesVisible()` / `allPlacesVisibleChanged()` ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin, elvisangelaccio
Cc: elvisangelaccio, meven, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200119/434f78f5/attachment-0001.html>