D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

David Faure noreply at phabricator.kde.org
Thu Jan 16 22:39:34 GMT 2020


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcoredirlister.cpp:2306
> +        d->settings.lstFilters.append(QRegularExpression(
> +            QRegularExpression::anchoredPattern(QRegularExpression::wildcardToRegularExpression(filter)),
> +            QRegularExpression::CaseInsensitiveOption));

I think you said this would anchor twice, in another review? Needs to be fixed then.

(Good for readability!)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200116/ed7a4623/attachment.html>


More information about the Kde-frameworks-devel mailing list