D26691: Optimize code when dropping files into the desktop

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  m_dropActions is conceptually linked to the menu we are showing
  It shouldn't a direct member variable of ContainmentInterface
  
  If we're following the existing pattern of this menu, it should be:
   QHash<KJob *, QList<QAction> *> m_dropJobs;
  
  Otherwise you have no overlap protection on something that's async
  
  I also am very confident if you either subclassed DropJob or used lamba's we can get rid of all of these hashes and make this code 10 billion times more readable. 
  (we have some crashers here, so it would be well worth it)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200116/7070ce6d/attachment-0001.html>