D26205: KWallet: Port QRegExp to QRegularExpression

Ahmad Samir noreply at phabricator.kde.org
Thu Jan 16 14:00:27 GMT 2020


ahmadsamir added a comment.


  In D26205#595111 <https://phabricator.kde.org/D26205#595111>, @blaze wrote:
  
  > > otherwise, we could just revert this patch
  >
  > The rest of the code is OK. The part that works funny is just the wildcard method, and since it's relatively new, I hope there could be a good workaround until the situation stabilizes
  
  
  I still fail to see what's broken, I tested with the system kwallet (5.65 on tumbleweed) and I don't see any difference between it and a build from a git checkout; i.e. falkon doesn't show the saved passwords after restarting it. I've already submitted another diff to fix the doubly-anchored pattern issue.
  
  Could you give me another test case? I want to see what's broken to try and fix it.
  
  Thanks in advance.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200116/e5fb5a40/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list