D26707: Fix QRegularExpression::wildcardToRegularExpression() usage
Ahmad Samir
noreply at phabricator.kde.org
Thu Jan 16 13:59:27 GMT 2020
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
It turns out that QRegularExpression::wildcardToRegularExpression() returns
an anchored (with \A and \z) pattern, so using anchoredPattern() in such
cases would actually anchor the pattern twice, which is obviously wrong.
Thanks to Mikołaj Płomieński (blaze) for catching it in
https://phabricator.kde.org/D26205#594891
TEST PLAN
make && ctest
REPOSITORY
R311 KWallet
BRANCH
l-qregularexpression-wildcard (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26707
AFFECTED FILES
src/api/KWallet/kwallet.cpp
src/runtime/kwalletd/backend/kwalletbackend.cc
To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200116/f552fc80/attachment.html>
More information about the Kde-frameworks-devel
mailing list