D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Thu Jan 16 09:16:00 GMT 2020


leinir added a comment.


  Thanks to David for making me look at that again, the original choice was based on a false-positive test

INLINE COMMENTS

> davidedmundson wrote in quickengine.h:54
> Why QObject here?
> 
> One of the main advantages of using QQmlListProperty over QList<QObject*> is that you can specify the derived type.

Quite simply because i, in my test code, had something around the wrong way... Updated patch incoming.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26543

To: leinir, #frameworks, #plasma, ngraham, broulik, mart
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200116/e95a95bc/attachment.html>


More information about the Kde-frameworks-devel mailing list