D26691: Optimize code when dropping files into the desktop

Anthony Fieroni noreply at phabricator.kde.org
Thu Jan 16 08:31:21 GMT 2020


anthonyfieroni added inline comments.

INLINE COMMENTS

> containmentinterface.cpp:589
> +    }
> +    qDebug() << "clearDataForMimeJob() ends.";
>  }

Don't add uncategorized qDebug, i see it exists in code base but they should be ported as well.

> containmentinterface.cpp:816-819
> +            //choices->exec();
>          } else {
> -            dropJob->setApplicationActions(dropActions);
> +            //dropJob->setApplicationActions(m_dropActions);
>          }

Remove, don't leave commented code

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart
Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200116/49f589ab/attachment.html>


More information about the Kde-frameworks-devel mailing list