D25660: Decouple KBookmarksMenu from KActionCollection

Nicolas Fella noreply at phabricator.kde.org
Wed Jan 15 22:32:19 GMT 2020


nicolasfella updated this revision to Diff 73666.
nicolasfella marked 11 inline comments as done.
nicolasfella added a comment.


  - Decouple from KActionCollection
  - Set action name
  - Restore root check
  - Use constructor delegation
  - Update since
  - fix docs
  - Docs fixes
  - Use QString()
  - Make methods const
  - Rename parameter

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25660?vs=70694&id=73666

BRANCH
  addd

REVISION DETAIL
  https://phabricator.kde.org/D25660

AFFECTED FILES
  src/CMakeLists.txt
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, dfaure, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200115/d37c8157/attachment.html>


More information about the Kde-frameworks-devel mailing list