D26205: KWallet: Port QRegExp to QRegularExpression

[Albert Astals Cid]

aacid added a comment.


  In D26205#595080 <https://phabricator.kde.org/D26205#595080>, @ahmadsamir wrote:
  
  > In D26205#595034 <https://phabricator.kde.org/D26205#595034>, @blaze wrote:
  >
  > > https://github.com/KDE/falkon/blob/master/src/plugins/KDEFrameworksIntegration/kwalletpasswordbackend.cpp#L187
  > >
  > >   QMap<QString, QByteArray> entries;
  > >   if (m_wallet->readEntryList("*", entries) != 0) {
  > >       qWarning() << "KWalletPasswordBackend::initialize Cannot read entries!";
  > >       return;
  > >   }
  > >   
  > >
  > > This is the problematic code. As you can see it uses "*" as a wildcard. So may be it is possible just to use a different wildcard and it could be solved IDK
  >
  >
  > OK, I'll see if I can make it work and also fix the double-anchored issue; in a new diff, otherwise, we could just revert this patch.
  >
  > @apol, @aacid WDYT?
  
  
  I was going to be silent here, but since you asked my opinion is this, if you are not going to test the code you are changing, you should stop changing code. And by reading the comments it seems you aren't testing it, so either start testing it or stop doing blind changes.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D26205

To: ahmadsamir, #frameworks, aacid, apol
Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200115/b1095f19/attachment.html>