D26650: Use KService to look for Filelight
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Jan 15 08:18:40 GMT 2020
broulik added inline comments.
INLINE COMMENTS
> kpropertiesdialog.cpp:1114
> + d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon()));
> + connect(d->m_sizeDetailsButton, &QPushButton::clicked, this, [this, service]() {
> + KRun::runApplication(*service, { properties->url() }, properties->window());});
Not sure copying that pointer into the lambda is a good idea?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26650
To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200115/4294eb46/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list