D26650: Use KService to look for Filelight

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1114
> +            d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon()));
>              connect(d->m_sizeDetailsButton, &QPushButton::clicked, this, &KFilePropsPlugin::slotSizeDetails);
>              sizelay->addWidget(d->m_sizeDetailsButton, 0);

We don't need to reparse desktop file on every click just make it

  connect(d->m_sizeDetailsButton, &QPushButton::clicked, this, [this, service]() {
      KRun::runApplication(*service, { properties->url() }, properties->window());
  });

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200114/7903e975/attachment-0001.html>