D26650: Use KService to look for Filelight

[Nathaniel Graham]

ngraham added a comment.


  Much better, thanks. Remember to mark inline comments as "Done" once you've addressed them.

INLINE COMMENTS

> kpropertiesdialog.cpp:1109
>  
> -        if (!QStandardPaths::findExecutable(QStringLiteral("filelight")).isEmpty()) {
> +        KService::Ptr serv = KService::serviceByDesktopName(QStringLiteral("org.kde.filelight"));
> +

prefer descriptive variable names; "service" is better than "serv"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200114/fe574991/attachment.html>