D26659: [KCoreDirLister] Port QRegExp to QRegularExpression
Ahmad Samir
noreply at phabricator.kde.org
Tue Jan 14 12:18:15 GMT 2020
ahmadsamir created this revision.
ahmadsamir added a reviewer: dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
doNameFilter() was the only protected function that took a QRegExp param.,
but I couldn't find any users of it in KDE. Also changed lstFilters from
from QList to QVector.
Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern(),
and QRegExp::Wildcard with QRegularExpression::wildcardToRegularExpression().
Note that setNameFilter() has some users, it took a QString param.,
which is used as the pattern for a QRegularExpression, but there are
differences between valid QRegExp and QRegularExpression patterns.
TEST PLAN
make && ctest
REPOSITORY
R241 KIO
BRANCH
l-qregexp-deprecate (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26659
AFFECTED FILES
src/core/kcoredirlister.cpp
src/core/kcoredirlister.h
src/core/kcoredirlister_p.h
To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200114/538ed1c4/attachment.html>
More information about the Kde-frameworks-devel
mailing list