D26650: Use KService to look for Filelight

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1455
>      // Open the current folder in filelight
> -    KRun::run((QStandardPaths::findExecutable(QStringLiteral("filelight"))), { properties->url() }, properties->window(), QStringLiteral("Filelight"), QStringLiteral("filelight"));
> +    KService::Ptr serv = KService::serviceByDesktopName(QStringLiteral("org.kde.filelight"));
> +    KRun::runApplication(*serv, { properties->url() }, properties->window());

service can be nullptr, add a check

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200114/15f40d08/attachment.html>