D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in desktopexecparser.cpp:213
> Move result of method call into local const variable. The usual range-for-detaches problem.
> 
> Can you call mimeTypes() instead of serviceTypes() here? I'm trying to slowly split the two notions, after it all got mixed up long ago.

> Can you call mimeTypes() instead of serviceTypes() here? I'm trying to slowly split the two notions, after it all got mixed up long ago.

No in fact, "x-scheme-handler/<protocol>" are not included in KService::mimeTypes() :

>   if (db.mimeTypeForName(sv).isValid()) { // keep only mimetypes, filter out servicetypes

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26557

To: meven, ervin, ngraham, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200112/bf51445e/attachment.html>