D26484: Popup menu again to reposition it

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sorry I have no idea about the calling side in plasma. It sounds buggy indeed, if those are all calls on the same DropJob instance.

INLINE COMMENTS

> dropjob.cpp:409
>      d->m_appActions = actions;
> +    auto m_relativePos = d->m_relativePos;
> +    auto window = KJobWidgets::window(this);

The m_ prefix is for member variables. Don't use it for a local stack variable.

> dropjob.cpp:414
>          menu->addExtraActions(d->m_appActions, d->m_pluginActions);
> +        // popup again to update position. BUG: 415917
> +        menu->popup(window ? window->mapToGlobal(m_relativePos) : QCursor::pos());

Doesn't this flicker?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200111/0fb6ff52/attachment.html>