D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

David Edmundson noreply at phabricator.kde.org
Thu Jan 9 17:07:07 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in ksortfilterproxymodel.cpp:101
> In setFilterRegExp(), QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression &) is used, so IIUC here it should be :
> QSortFilterProxyModel::filterRegularExpression().pattern()

I'm not sure your comments are still valid, we switched to using the superclass QSortFilterProxyModel's methods, and don't shadow that part here.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: ahmadsamir, broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200109/6e093298/attachment.html>


More information about the Kde-frameworks-devel mailing list